Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo bench --fails to build in MacOSX #591

Closed
gnzlbg opened this issue Jul 3, 2019 · 4 comments
Closed

cargo bench --fails to build in MacOSX #591

gnzlbg opened this issue Jul 3, 2019 · 4 comments
Labels

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 3, 2019

cargo bench --all fails to build in MacOSX

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Jul 3, 2019

Following the instructions in HACKING.md and just ./bench/run rust produces the error:

error: Package regex v1.1.7 (/Users/gnzlbg/projects/sideprojects/regex) does not have these features: re-rust

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Jul 3, 2019

(cd bench && ./run rust) appears to work

@BurntSushi BurntSushi added the doc label Jul 3, 2019
@BurntSushi
Copy link
Member

Indeed, I think this is just a documentation issue. Ideally I'd like to overhaul the benchmarks some day, but it's a huge task given both the number of benchmarks and the number of regex engines that are benchmarked.

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Jul 3, 2019

I'll update #589 with a fix soon.

gnzlbg added a commit to gnzlbg/regex that referenced this issue Jul 3, 2019
gnzlbg added a commit to gnzlbg/regex that referenced this issue Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants