Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automata/meta: revert broadening of reverse suffix optimization #1111

Merged
merged 1 commit into from
Oct 16, 2023

Commits on Oct 16, 2023

  1. automata/meta: revert broadening of reverse suffix optimization

    This reverts commit 8a8d599 and
    includes a regression test, as well as a tweak to a log message.
    
    Essentially, the broadening was improper. We have to be careful when
    dealing with suffixes as opposed to prefixes. Namely, my logic
    previously was that the broadening was okay because we were already
    doing it for the reverse inner optimization. But the reverse inner
    optimization works with prefixes, not suffixes. So the comparison wasn't
    quite correct.
    
    This goes back to only applying the reverse suffix optimization when
    there is a non-empty single common suffix.
    
    Fixes #1110
    Ref astral-sh/ruff#7980
    BurntSushi committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7eefc5d View commit details
    Browse the repository at this point in the history