make additional prefileter metadata public #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
force-pushed
the
prefilter
branch
from
6cffa53
to
867da13
Compare
BurntSushi
requested changes
Jan 25, 2024
pascalkuthe
force-pushed
the
prefilter
branch
from
867da13
to
11bff34
Compare
|
done, thanks for the quick feedback! |
BurntSushi
approved these changes
Jan 25, 2024
|
This PR is on crates.io in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes that I mentioned a while ago in #425
I now have a fully working streaming regex implementation at https://github.com/pascalkuthe/regex-cursor. These two APIs are the last two blockers before I can make helix switch to that implementation (we don't allow git dependencies/patches).
Prefilter::is_fastpublic. Necessary to implement a meta engine downstream (also useful for any other downstream user that wants to write a custom meta engine)