rollup recent PRs + miscellaneous fixes #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing "EndText" matching, it is necessary to check whether the current position matches the input text length. However, when capturing a submatch using the matching result of DFA, "EndText" matching wasn't actually performed correctly because the input text is sliced. By applying this patch we specify the match end position by the argument "end", not using slice when performing capture with the matching result of DFA. Fixes #557, Closes #561
Closes #500
This updates the README examples to drop the use of `extern crate`. We do include instructions to add it, but only for Rust 2015. Closes #552
This commit exposes two new functions in regex's C API: rure_escape_must and rure_cstring_free. These permit escaping a pattern such that it contains no special regex meta characters. Currently, we only expose a routine that will abort the process if it fails, but we document the precise error conditions. A more flexible but less convenient routine should ideally be exposed in the future, but that needs a bit more API design than what's here. Closes #537
This fixes a bug where the HIR translator would panic on regexes such as
`(?i){1}` since it assumes that every repetition operator has a valid
sub-expression, and `(?i)` is not actually a sub-expression (but is more
like a directive instead).
Previously, we fixed this same bug for *uncounted* repetitions in commit
17764ff (for bug #465), but we did not fix it for counted repetitions.
We apply the same fix here.
Fixes #555
This fixes yet another bug with our handling of (?flags) directives in the regex. This time, we try to be a bit more principled and specifically treat a (?flags) directive as a valid empty sub-expression. While this means we could remove errors reported from previous fixes for things like `(?i)+`, we retain those for now since they are a bit weird. Although `((?i))+` is now allowed, which is equivalent. We should probably allow `(?i)+` in the future for consistency sake. Fixes #527
It's impossible to do this without the cooperation of maintainers from other core crates, and some of them do not see the value in doing this.
This was referenced Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rolls up a few PRs and fixes a couple small parser related bugs. See the commit messages for details.