Add missing implementations of core iterator traits #734
Conversation
|
LGTM! I think there are a couple of impls we don't need though? |
- Add missing implementations of FusedIterator. - Add missing implementations of ExactSizeIterator. - Add missing overrides of `Iterator::count` when wrapping a slice iterator. - Add missing overrides of `Iterator::size_hint` when size hint is known.
lopopolo
force-pushed the
lopopolo:missing-iterator-impls
branch
from
489ad04
to
d8167d2
|
@BurntSushi I've removed the impls on internal types you flagged. |
|
Thanks! |
This was referenced Mar 12, 2021
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Iterator::countwhen wrapping a slice iterator.Iterator::size_hintwhen size hint is known.Context: I'm building an implementation of Ruby
Regexpon top of theregexcrate, and having guarantees around whether iterators are fused will allow me to implement these traits on my wrappingIterators as well.