You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The message today states "Team member @ghosthas proposed to merge this. The next step is review by the rest of the tagged teams:". Review is imprecise because it can sort of imply code review. By changing to explicitly state what is being asked, we can avoid some confusion.
The text was updated successfully, but these errors were encountered:
I agree that the current wording is too vague, but I'm not sure that "FCP approval" is the phrase I would choose to replace it. Can you think of an option you'd find clearer that doesn't rely on any Rust-governance-process-specific jargon?
I think the implication of code review is exactly the right analogy personally.
The team responsible should review the document and associated discussion to reach a conclusion.
"review and approval" seems reasonable, but I agree with @Centril that we want to keep the implication of "review this carefully".
Havvy
changed the title
"review" -> "FCP approval" in @rfcbot merge message
"review" -> "FCP approval" or similar in @rfcbot merge message
Sep 25, 2018
The message today states "Team member @ghosthas proposed to merge this. The next step is review by the rest of the tagged teams:". Review is imprecise because it can sort of imply code review. By changing to explicitly state what is being asked, we can avoid some confusion.
The text was updated successfully, but these errors were encountered: