Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"review" -> "FCP approval" or similar in @rfcbot merge message #244

Open
Havvy opened this issue Sep 15, 2018 · 3 comments
Open

"review" -> "FCP approval" or similar in @rfcbot merge message #244

Havvy opened this issue Sep 15, 2018 · 3 comments

Comments

@Havvy
Copy link

Havvy commented Sep 15, 2018

The message today states "Team member @ghosthas proposed to merge this. The next step is review by the rest of the tagged teams:". Review is imprecise because it can sort of imply code review. By changing to explicitly state what is being asked, we can avoid some confusion.

@anp
Copy link
Member

anp commented Sep 17, 2018

I agree that the current wording is too vague, but I'm not sure that "FCP approval" is the phrase I would choose to replace it. Can you think of an option you'd find clearer that doesn't rely on any Rust-governance-process-specific jargon?

@Centril
Copy link
Contributor

Centril commented Sep 17, 2018

I think the implication of code review is exactly the right analogy personally.
The team responsible should review the document and associated discussion to reach a conclusion.

@joshtriplett
Copy link
Member

"review and approval" seems reasonable, but I agree with @Centril that we want to keep the implication of "review this carefully".

@Havvy Havvy changed the title "review" -> "FCP approval" in @rfcbot merge message "review" -> "FCP approval" or similar in @rfcbot merge message Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants