Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCPs proposed by the addition of labels to an issue with a previously-ignored command #286

Open
anp opened this issue Jun 20, 2020 · 2 comments

Comments

@anp
Copy link
Member

anp commented Jun 20, 2020

An example:

  1. @nikomatsakis asks for a merge in illumos toolchain builds compiler-team#279 (comment)
  2. rfcbot ignores because no T-* labels
  3. @nikomatsakis adds T-compiler in illumos toolchain builds compiler-team#279 (comment)
  4. rfcbot continues to do nothing, presumably because we only check if a comment is an fcp start when the comment changes, not the issue?
  5. @nikomatsakis invokes again in illumos toolchain builds compiler-team#279 (comment) and it works

Ideally, rfcbot could detect the state change in (3) as representing a proposal. I'm not sure it's a good idea to do that without also making sure that modifying team labels mid-FCP works correctly. If that's not feasible, it would at least be good for rfcbot to post a comment when (3) happens.

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jun 22, 2020

If that's not feasible, it would at least be good for rfcbot to post a comment when (3) happens.

This would be great I think and totally sufficient

@nikomatsakis
Copy link
Contributor

Let me re-phrase: I think posting a comment is probably the most important thing and something that it ought to do regardless. That comment should explain what other steps (if any) are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants