Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Private trait items #275

Open
rust-highfive opened this issue Sep 24, 2014 · 5 comments
Open

RFC: Private trait items #275

rust-highfive opened this issue Sep 24, 2014 · 5 comments
Labels
A-privacy Privacy related proposals & ideas A-traits Trait system related proposals & ideas A-typesystem Type system related proposals & ideas postponed RFCs that have been postponed and may be revisited at a later time. T-lang Relevant to the language team, which will review and decide on the RFC.

Comments

@rust-highfive
Copy link

Tracking issue for postponed PR #52
@rust-highfive rust-highfive added the postponed RFCs that have been postponed and may be revisited at a later time. label Sep 24, 2014
@nrc nrc added the T-lang Relevant to the language team, which will review and decide on the RFC. label Aug 17, 2016
withoutboats pushed a commit to withoutboats/rfcs that referenced this issue Jan 15, 2017
@alexcrichton
Merge pull request rust-lang#275 from alexcrichton/buffer-start-send
9a0ab4a 
Send as many items as possible before poll_complete
@crumblingstatue crumblingstatue mentioned this issue Jun 17, 2017
Closed
4 tasks
@crumblingstatue
Copy link

crumblingstatue commented Jun 17, 2017 •
edited
Loading

We could use pub(restricted) for this, instead of reintroducing priv.

In particular, maybe we could use pub(impl) to restrict visibility to the "implementation" of the trait.

@crumblingstatue crumblingstatue mentioned this issue Jun 17, 2017
Open
@petrochenkov
Copy link
Contributor

Closing in favor of #2028

@crumblingstatue
Copy link

@petrochenkov
As I understand it, your proposal is different, as it disallows implementing a private trait item.

This RFC is for trait items that can be implemented, but not visible to users.

@petrochenkov
Copy link
Contributor

Hm, indeed, that RFC proposes something very different (I wouldn't call that "private trait items").

@petrochenkov petrochenkov reopened this Jun 17, 2017
@crumblingstatue crumblingstatue mentioned this issue Jun 17, 2017
Closed
@Restioson Restioson mentioned this issue Jan 3, 2018
Closed
@Restioson
Copy link

Hi, I just wanted to cross post my use case from #52 here so it can hopefully be given some attention.

Perhaps the RFC could be rewritten with some of the new ideas such as using pub(restricted) syntax instead of priv keyword or defaultly private methods?

@Centril Centril added A-traits Trait system related proposals & ideas A-privacy Privacy related proposals & ideas A-typesystem Type system related proposals & ideas labels Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-privacy Privacy related proposals & ideas A-traits Trait system related proposals & ideas A-typesystem Type system related proposals & ideas postponed RFCs that have been postponed and may be revisited at a later time. T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nrc @Centril @crumblingstatue @petrochenkov @Restioson @rust-highfive