Skip to content

/rfcs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Private trait items #275

Open
rust-highfive opened this Issue Sep 24, 2014 · 5 comments

Comments

Assignees
No one assigned
Labels
A-privacy A-traits A-typesystem T-lang postponed
Projects
None yet
Milestone
No milestone
6 participants
@rust-highfive @crumblingstatue @petrochenkov @Restioson @nrc @Centril
@rust-highfive
Copy link

rust-highfive commented Sep 24, 2014

Tracking issue for postponed PR #52

@rust-highfive rust-highfive added the postponed label Sep 24, 2014

@nrc nrc added the T-lang label Aug 17, 2016

withoutboats pushed a commit to withoutboats/rfcs that referenced this issue Jan 15, 2017

@alexcrichton
Merge pull request rust-lang#275 from alexcrichton/buffer-start-send 
Send as many items as possible before poll_complete
9a0ab4a

@crumblingstatue crumblingstatue referenced this issue Jun 17, 2017

Closed

Allow fields in traits that map to lvalues in impl'ing type #1546

0 of 4 tasks complete
@crumblingstatue

This comment has been minimized.

Sign in to view
Copy link

crumblingstatue commented Jun 17, 2017 •
edited

We could use pub(restricted) for this, instead of reintroducing priv.

In particular, maybe we could use pub(impl) to restrict visibility to the "implementation" of the trait.

@crumblingstatue crumblingstatue referenced this issue Jun 17, 2017

Open

permit impls to map to private fields #6

@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Jun 17, 2017

Closing in favor of #2028

@petrochenkov petrochenkov closed this Jun 17, 2017

@crumblingstatue

This comment has been minimized.

Sign in to view
Copy link

crumblingstatue commented Jun 17, 2017

@petrochenkov
As I understand it, your proposal is different, as it disallows implementing a private trait item.

This RFC is for trait items that can be implemented, but not visible to users.
@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Jun 17, 2017

Hm, indeed, that RFC proposes something very different (I wouldn't call that "private trait items").

@petrochenkov petrochenkov reopened this Jun 17, 2017

@crumblingstatue crumblingstatue referenced this issue Jun 17, 2017

Closed

Privacy for enum variants and trait items #2028

@Restioson Restioson referenced this issue Jan 3, 2018

Closed

RFC: Private trait items #52

@Restioson

This comment has been minimized.

Sign in to view
Copy link

Restioson commented Jan 17, 2018

Hi, I just wanted to cross post my use case from #52 here so it can hopefully be given some attention.

Perhaps the RFC could be rewritten with some of the new ideas such as using pub(restricted) syntax instead of priv keyword or defaultly private methods?

@Centril Centril added A-traits A-privacy A-typesystem labels Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.