Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC to put the RFCs repo under license terms #2044

Merged
merged 2 commits into from
Jul 24, 2017
Merged

RFC to put the RFCs repo under license terms #2044

merged 2 commits into from
Jul 24, 2017

Conversation

est31
Copy link
Member

@est31 est31 commented Jun 26, 2017 •
edited

Rendered

Fixes #1259

This was referenced Jun 26, 2017
Closed
Open
tomprince
tomprince reviewed Jun 26, 2017
View reviewed changes
text/0000-license-rfcs.md Outdated
[considered for merging].

This puts a responsibility on anyone who is merging RFCs to check for a
license header.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be handled by a tool, rather than a person.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/rust has a tool for this, but the rfc process is highly manual, and the way PRs get merged is different as well. Introducing a tool only for this purpose seems a bit much imo. Maybe we can do this after the transition period is over, and we still see files without a header being proposed.

@aturon aturon added the T-core Relevant to the core team, which will review and decide on the RFC. label Jun 26, 2017
@aturon aturon self-assigned this Jun 26, 2017
@aturon
Copy link
Member

aturon commented Jul 12, 2017

@est31 Thanks much for this RFC! We talked about it in the core team today, and everyone agrees we should take this step, and in the way you've described. As such:

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jul 12, 2017 •
edited by aturon

Team member @aturon has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. label Jul 12, 2017
@aturon
Copy link
Member

aturon commented Jul 12, 2017

Core team members: I've taken the liberty of checking off your review boxes given our discussion today, which will start a 10 day FCP period. If you have any issues with that, please leave a comment!

@rfcbot
Copy link
Collaborator

rfcbot commented Jul 12, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. and removed proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. labels Jul 12, 2017
@mgattozzi
Copy link
Contributor

This is excellent and definitely future proofs this repo going forward. Considering most Rust code is Apache-2.0/MIT I'm all for it :D

@rfcbot
Copy link
Collaborator

rfcbot commented Jul 22, 2017

The final comment period is now complete.

@est31 est31 mentioned this pull request Jul 24, 2017
Open
7 tasks
@aturon aturon merged commit 1c07d02 into rust-lang:master Jul 24, 2017
@aturon
Copy link
Member

aturon commented Jul 24, 2017

Huzzah! The RFC has been merged! Tracking issue.

This was referenced Jul 25, 2017
Open
Closed
Open
Open
@est31 est31 mentioned this pull request Aug 5, 2017
Closed
24 tasks
@Centril Centril added the A-meta Proposals about how we make proposals label Nov 23, 2018
@rust-lang rust-lang locked as spam and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomprince tomprince tomprince left review comments

Assignees

@aturon aturon

Labels
A-meta Proposals about how we make proposals final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. T-core Relevant to the core team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does this repo need a LICENSE or COPYING file?
6 participants
@est31 @aturon @rfcbot @mgattozzi @tomprince @Centril