Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline assembly #2873

Merged
merged 68 commits into from Jul 20, 2020
Merged

Inline assembly #2873

merged 68 commits into from Jul 20, 2020

Commits on Jan 13, 2020

  1. Add inline asm RFC

    @Amanieu
    Amanieu committed Jan 13, 2020
    Copy the full SHA
    5559913 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Minor corrections

    @Amanieu
    Amanieu committed Jan 14, 2020
    Copy the full SHA
    4edab76 View commit details
    Browse the repository at this point in the history

  2. More minor corrections

    @Amanieu
    Amanieu committed Jan 14, 2020
    Copy the full SHA
    03f22fe View commit details
    Browse the repository at this point in the history

  3. Oops

    @Amanieu
    Amanieu committed Jan 14, 2020
    Copy the full SHA
    31cab5e View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Add a section on rules for inline asm

    @Amanieu
    Amanieu committed Jan 21, 2020
    Copy the full SHA
    add2123 View commit details
    Browse the repository at this point in the history

  2. Rename flags() to options()

    @Amanieu
    Amanieu committed Jan 21, 2020
    Copy the full SHA
    fad338a View commit details
    Browse the repository at this point in the history

  3. Clarify support for non-LLVM backends

    @Amanieu
    Amanieu committed Jan 21, 2020
    Copy the full SHA
    806228f View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Clarify reg class under ARM Thumb1

    @Amanieu
    Amanieu committed Jan 22, 2020
    Copy the full SHA
    fa90ad2 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Clarify rules

    @Amanieu
    Amanieu committed Jan 24, 2020
    Copy the full SHA
    fc99a8c View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2020

  1. Rename imm to const

    @Amanieu
    Amanieu committed Jan 25, 2020
    Copy the full SHA
    2572476 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Rework register classes and modifiers

    @Amanieu
    Amanieu committed Jan 30, 2020
    Copy the full SHA
    93b179c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2020

  1. Fix minor typos

    @Amanieu
    Amanieu committed Feb 9, 2020
    Copy the full SHA
    d82b70d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Disallow specifying the same register as both an input and an output … 

    …(use inout instead)
    @Amanieu
    Amanieu committed Feb 11, 2020
    Copy the full SHA
    2adfde8 View commit details
    Browse the repository at this point in the history

  2. Clarify implicit operands that come after named operands

    @Amanieu
    Amanieu committed Feb 11, 2020
    Copy the full SHA
    89cbf28 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2020

  1. Expand on default modifier used for registers

    @Amanieu
    Amanieu committed Feb 16, 2020
    Copy the full SHA
    5884b7f View commit details
    Browse the repository at this point in the history

  2. Explicit register operands can't be used in the template

    @Amanieu
    Amanieu committed Feb 16, 2020
    Copy the full SHA
    f427d17 View commit details
    Browse the repository at this point in the history

  3. Add rationale for not supporting AT&T syntax

    @Amanieu
    Amanieu committed Feb 16, 2020
    Copy the full SHA
    feecfa1 View commit details
    Browse the repository at this point in the history

  4. Add rationale for not validating the generating asm in rustc.

    @Amanieu
    Amanieu committed Feb 16, 2020
    Copy the full SHA
    15c7aa8 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Remove restriction on sym needing to be from current crate.

    @Amanieu
    Amanieu committed Feb 24, 2020
    Copy the full SHA
    7d066ce View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Fix typos

    @Amanieu
    Amanieu committed Feb 25, 2020
    Copy the full SHA
    44853af View commit details
    Browse the repository at this point in the history

  2. Fix some details to match WIP implementation

    @Amanieu
    Amanieu committed Feb 25, 2020
    Copy the full SHA
    b5d854d View commit details
    Browse the repository at this point in the history

  3. Clarify that the compiler must treat asm! as a black box

    @Amanieu
    Amanieu committed Feb 25, 2020
    Copy the full SHA
    6b3a129 View commit details
    Browse the repository at this point in the history

  4. Add more examples of asm! usage to motivation

    @Amanieu
    Amanieu committed Feb 25, 2020
    Copy the full SHA
    d83a1e1 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Add type whitelist for each register class

    @Amanieu
    Amanieu committed Feb 28, 2020
    Copy the full SHA
    904b71e View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @Amanieu
    Amanieu committed Feb 28, 2020
    Copy the full SHA
    a48259d View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. x[16-31] don't exist on RV32E

    @Amanieu
    Amanieu committed Feb 29, 2020
    Copy the full SHA
    843b6cf View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. Clarify rules

    @Amanieu
    Amanieu committed Mar 1, 2020
    Copy the full SHA
    a1467e2 View commit details
    Browse the repository at this point in the history

  2. Pointers are i16 on some targets

    @Amanieu
    Amanieu committed Mar 1, 2020
    Copy the full SHA
    0f4ffff View commit details
    Browse the repository at this point in the history

  3. Update semantics of "pure" option

    @Amanieu
    Amanieu committed Mar 1, 2020
    Copy the full SHA
    8c54738 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Clarify that locals are not dropped before entering a noreturn asm

    @Amanieu
    Amanieu committed Mar 4, 2020
    Copy the full SHA
    2d431ab View commit details
    Browse the repository at this point in the history

  2. Clarify that x86 high byte registers are never allocated.

    @Amanieu
    Amanieu committed Mar 4, 2020
    Copy the full SHA
    7ddeedc View commit details
    Browse the repository at this point in the history

  3. Clarify the meaning of undefined values on entry to asm

    @Amanieu
    Amanieu committed Mar 4, 2020
    Copy the full SHA
    571474c View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Fix outdated wording on template modifiers

    @Amanieu
    Amanieu committed Mar 5, 2020
    Copy the full SHA
    d8fd770 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Add rationale for not including arch name in asm!

    @Amanieu
    Amanieu committed Mar 6, 2020
    Copy the full SHA
    88d4f21 View commit details
    Browse the repository at this point in the history

  2. Add rationale for register names as string literals

    @Amanieu
    Amanieu committed Mar 6, 2020
    Copy the full SHA
    df8388f View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @Amanieu
    Amanieu committed Mar 6, 2020
    Copy the full SHA
    5554950 View commit details
    Browse the repository at this point in the history

  4. Clarify rules for context switching and noreturn

    @Amanieu
    Amanieu committed Mar 6, 2020
    Copy the full SHA
    d0a743a View commit details
    Browse the repository at this point in the history

  5. Clarify that the semantics of the asm string are target-specific

    @Amanieu
    Amanieu committed Mar 6, 2020
    Copy the full SHA
    1738eec View commit details
    Browse the repository at this point in the history

  6. Fix outdated text regarding _ labels

    @Amanieu
    Amanieu committed Mar 6, 2020
    Copy the full SHA
    8f2871e View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. Allow trailing commas in syntax

    @Amanieu
    Amanieu committed Mar 7, 2020
    Copy the full SHA
    651d152 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. Minor fixes

    @Amanieu
    Amanieu committed Mar 15, 2020
    Copy the full SHA
    766290f View commit details
    Browse the repository at this point in the history

  2. Add namespacing as an unresolved question

    @Amanieu
    Amanieu committed Mar 15, 2020
    Copy the full SHA
    ff3400a View commit details
    Browse the repository at this point in the history

  3. Add drawback on post-monomorphization errors

    @Amanieu
    Amanieu committed Mar 15, 2020
    Copy the full SHA
    db1743a View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Add an alternative about operands before the template string

    @Amanieu
    Amanieu committed Mar 17, 2020
    Copy the full SHA
    014624e View commit details
    Browse the repository at this point in the history

  2. Clarify that the compiler errors if the target doesn't support asm!

    @Amanieu
    Amanieu committed Mar 17, 2020
    Copy the full SHA
    784a13f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Explain why inlateout can't be used in example

    @Amanieu
    Amanieu committed Mar 18, 2020
    Copy the full SHA
    14b47f4 View commit details
    Browse the repository at this point in the history

  2. Add comments on CPUID arguments

    @Amanieu
    Amanieu committed Mar 18, 2020
    Copy the full SHA
    3490ce6 View commit details
    Browse the repository at this point in the history

  3. Assembly code that does not conform to the GAS syntax will result in … 

    …assembler-specific behavior.
    @Amanieu
    Amanieu committed Mar 18, 2020
    Copy the full SHA
    8d8b1d3 View commit details
    Browse the repository at this point in the history

  4. Clarify nounwind rule

    @Amanieu
    Amanieu committed Mar 18, 2020
    Copy the full SHA
    66bb5f9 View commit details
    Browse the repository at this point in the history

  5. Remove references to volatile_read/volatile_write

    @Amanieu
    Amanieu committed Mar 18, 2020
    Copy the full SHA
    ec6a4ce View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Specify that ARM uses UAL syntax

    @Amanieu
    Amanieu committed Apr 23, 2020
    Copy the full SHA
    491d29f View commit details
    Browse the repository at this point in the history

  2. Add sym to guide-level explanation

    @Amanieu
    Amanieu committed Apr 23, 2020
    Copy the full SHA
    35db0a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Add support for high byte registers on x86

    @Amanieu
    Amanieu committed Apr 28, 2020
    Copy the full SHA
    f0cd800 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Update wording on high byte registers

    @Amanieu
    Amanieu committed May 1, 2020
    Copy the full SHA
    cef9246 View commit details
    Browse the repository at this point in the history

  2. Add att_syntax option for AT&T syntax

    @Amanieu
    Amanieu committed May 1, 2020
    Copy the full SHA
    5dd81ea View commit details
    Browse the repository at this point in the history

  3. Add rationale for defaulting to Intel syntax

    @Amanieu
    Amanieu committed May 1, 2020
    Copy the full SHA
    52d0096 View commit details
    Browse the repository at this point in the history

  4. Clarify that inout requires a mutable place

    @Amanieu
    Amanieu committed May 1, 2020
    Copy the full SHA
    a3c53ec View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. More clarifications and formatting fixes

    @Amanieu
    Amanieu committed May 9, 2020
    Copy the full SHA
    f97d53a View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Use u32 for CPUID example

    @Amanieu
    Amanieu committed May 11, 2020
    Copy the full SHA
    62fe4e4 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. Clarify that stdarch vector types are usable with asm!

    @Amanieu
    Amanieu committed May 16, 2020
    Copy the full SHA
    f45ca4b View commit details
    Browse the repository at this point in the history

  2. Clarify the evaluation order of asm! operands

    @Amanieu
    Amanieu committed May 16, 2020
    Copy the full SHA
    1dbeaf9 View commit details
    Browse the repository at this point in the history

  3. Update text/0000-inline-asm.md 

    Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
    @Amanieu @bjorn3
    Amanieu and bjorn3 committed May 16, 2020
    Copy the full SHA
    89f917e View commit details
    Browse the repository at this point in the history

  4. Clarify rules regarding the x86 direction flag

    @Amanieu
    Amanieu committed May 16, 2020
    Copy the full SHA
    3633849 View commit details
    Browse the repository at this point in the history

  5. Clarify rules around the use of symbols in asm code

    @Amanieu
    Amanieu committed May 16, 2020
    Copy the full SHA
    ae298d8 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Fix broken link

    @Amanieu
    Amanieu committed May 18, 2020
    Copy the full SHA
    65b1cf2 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Update text/0000-inline-asm.md 

    Co-authored-by: laizy <laizy@users.noreply.github.com>
    @Amanieu @laizy
    Amanieu and laizy committed Jun 2, 2020
    Copy the full SHA
    a03813d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Clarify wording around positional/named/register arguments

    @Amanieu
    Amanieu committed Jun 11, 2020
    Copy the full SHA
    087ac5c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. RFC 2873 (asm!): Allow multiple template string arguments 

    Interpret them as newline-separated.

Update examples and explanations for this change.
    @joshtriplett @Amanieu
    joshtriplett authored and Amanieu committed Jun 16, 2020
    Copy the full SHA
    733869a View commit details
    Browse the repository at this point in the history