Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destructuring assignment #2909

Merged
merged 29 commits into from
Oct 27, 2020
Merged

Destructuring assignment #2909

merged 29 commits into from
Oct 27, 2020

Commits on Apr 17, 2020

  1. Initial draft of destructuring_assignments RFC

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    1abbf0c View commit details
    Browse the repository at this point in the history

  2. Be explicit about pattern diagnostics

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    49e9b80 View commit details
    Browse the repository at this point in the history

  3. Alpha-rename

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    e2ea3c1 View commit details
    Browse the repository at this point in the history

  4. Explain desugaring for _ and ..

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    9d5cb89 View commit details
    Browse the repository at this point in the history

  5. Give examples in guide-level explanation

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    6d4afd5 View commit details
    Browse the repository at this point in the history

  6. Clarify order-of-execution

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    24404a3 View commit details
    Browse the repository at this point in the history

  7. Tweak the order-of-assignment text

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    7f3edec View commit details
    Browse the repository at this point in the history

  8. Add actual drawbacks

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    eab6125 View commit details
    Browse the repository at this point in the history

  9. Add link to implementation PoC

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    111b630 View commit details
    Browse the repository at this point in the history

  10. Add note about ref and &

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    c773c50 View commit details
    Browse the repository at this point in the history

  11. Add slice .. example

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    d7e5e61 View commit details
    Browse the repository at this point in the history

  12. Fix typo and make clarification

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    cd08452 View commit details
    Browse the repository at this point in the history

  13. Clarify that nested structures may be destructured

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    612bbbe View commit details
    Browse the repository at this point in the history

  14. Add a nested assignment to the first example

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    27f032e View commit details
    Browse the repository at this point in the history

  15. Add note about single-variant enums and #[non_exhaustive]

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    f0d8224 View commit details
    Browse the repository at this point in the history

  16. Add note about parentheses

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    7aa1e96 View commit details
    Browse the repository at this point in the history

  17. Extend list of unsupported patterns for comprehensiveness

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    b599f3e View commit details
    Browse the repository at this point in the history

  18. Mention that destructuring assignment is an expression

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    b79d556 View commit details
    Browse the repository at this point in the history

  19. Mention @

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    80b6f4d View commit details
    Browse the repository at this point in the history

  20. Add reference to alternative involving new keyword

    @varkor
    varkor committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    50a8dba View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. Give earlier example of non-ident lvalue

    @varkor
    varkor committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    e5cfd65 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2020

  1. Mention field shorthand

    @varkor
    varkor committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    db1a22b View commit details
    Browse the repository at this point in the history

  2. Add note about place expressions

    @varkor
    varkor committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    821dcc8 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2020

  1. Add notion of "assignee expression"

    @varkor
    varkor committed May 31, 2020
    Configuration menu
    Copy the full SHA
    ff995bb View commit details
    Browse the repository at this point in the history

  2. Make clarifications after review

    @varkor
    varkor committed May 31, 2020
    Configuration menu
    Copy the full SHA
    7120df9 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Default binding modes do not apply for destructuring assignment

    @varkor
    varkor committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    1595109 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Fix typo

    @varkor
    varkor committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    cfe880f View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Fix another typo 

    Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
    @varkor @workingjubilee
    varkor and workingjubilee committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9daec61 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Clarify behaviour of range expressions

    @varkor
    varkor committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    58091b6 View commit details
    Browse the repository at this point in the history