Rust Style Team

[joshtriplett]

This RFC charters the Rust Style Team, responsible for evolving the Rust style over time. This includes styling for new Rust constructs, as well as the evolution of the existing style over the course of Rust editions (without breaking backwards compatibility).

RFC 1607 proposed and motivated a process for determining code formatting guidelines and producing a style guide, via a temporary style team. That style guide was published as RFC 2436, and the style team wound up its operation and no longer exists. However, Rust has multiple ongoing needs for new determinations regarding Rust style, such as determining the style of new Rust constructs, and evolving the Rust style over time. Thus, this RFC re-charters the Rust Style Team as a non-temporary subteam.

The renewed need for the Rust style team began to arise in discussions of language constructs such as let-chaining (RFC 2497) and let-else (RFC 3137). New constructs like these, by default, get ignored and not formatted by rustfmt, and subsequently need formatting added. The rustfmt team has expressed a preference to not make style determinations itself; the rustfmt team would prefer to implement style determinations made by another team.

This RFC proposes re-chartering the style team, as originally specified in RFC 1607, to determine the Rust style. This includes:

• Making determinations about styling for new Rust constructs
• Evolving the existing Rust style
• Defining mechanisms to evolve the Rust style while taking backwards compatibility into account, such as via Rust editions or similar mechanisms

The initial members of the style team shall be:

• Lead: Caleb Cartwright (@calebcartwright)
• Jane Losare-Lusby (@yaahc)
• Josh Triplett (@joshtriplett)
• Michael Goulet (@compiler-errors)

Rendered

[thomcc]

Strong +1 from me.

This lets us avoid the issue we've run into with let-else, and is a better solution than my suggestion here, which was essentially to make it the responsibility of t-lang when signing off on RFCs with new syntax, which is insufficient due to it not handling cases where the feature evolves between the RFC and stabilization.

[calebcartwright]

Probably goes without saying, but I'm highly supportive of this proposal as well. Couple minor inline items that I overlooked during pre-post reads

[joshtriplett]

Multiple people have expressed a preference for the style team to have a single parent team, rather than two; in response, Caleb on behalf of rustfmt expressed a preference for the parent team to be lang. I've updated the RFC accordingly, and update the alternatives section to list the two-parent-team setup.

[joshtriplett]

Doing this half by hand and half with rfcbot:

Lang team, shall we approve the creation of the Rust Style team?

@rfcbot merge

Even though per the previous commit rustfmt will no longer be a parent team of the style team, the style team will still have a close working relationship with the rustfmt team. So, rustfmt team (@calebcartwright and @ytmimi), do you also approve the creation of the Rust style team? (Please feel free to respond with either a comment confirming or a comment raising any concerns you may have.)

[rfcbot]

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

• @cramertj
• @joshtriplett
• @nikomatsakis
• @pnkfelix
• @scottmcm

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[calebcartwright]

So, rustfmt team (@calebcartwright and @ytmimi), do you also approve the creation of the Rust style team? (Please feel free to respond with either a comment confirming or a comment raising any concerns you may have.)

I approve the creation of the team

[ytmimi]

I also approve the creation of the team!

[nikomatsakis]

@rfcbot reviewed

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.