Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Crates.io Team under the Dev Tools team #3595

Merged

Conversation

carols10cents
Copy link
Member

@carols10cents carols10cents commented Mar 26, 2024

This RFC proposes moving the Crates.io Team under the Dev Tools Team. This change has very little impact outside of the removal of the Crates.io Council representative. Crates.io Team interests will be represented by the Dev Tools team representative.

Rendered

@carols10cents carols10cents added the T-leadership-council Relevant to the Leadership Council, which will review and decide on this RFC. label Mar 26, 2024
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@carols10cents
Copy link
Member Author

@rfcbot fcp merge

As there haven't been any objections or other discussion, I'm proposing to merge this!

@rfcbot
Copy link
Collaborator

rfcbot commented Apr 5, 2024

Team member @carols10cents has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. labels Apr 5, 2024
@ehuss
Copy link
Contributor

ehuss commented Apr 5, 2024

Although I don't think there will be any objections, I would like to also have a clear approval from the devtools team as well. We don't have a formal process for adding teams, but I think just making checkboxes here should suffice. I'm checking @Manishearth's box since there is already an approval above.


## Be a subteam of both Dev tools and Infra

The Types team provides precedence for this; technically the Types team is a subteam of both the Compiler and Lang teams. However, the teams repo doesn't really support multiple inheritance. The Crates.io team would like to cultivate a closer relationship with the Cargo team especially, and thinks the relationship with the Infra team could be continued in the current manner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Crates.io team would like to cultivate a closer relationship with the Cargo team

I feel like this is the key argument for why this RFC proposes T-DevTools as the parent rather than T-Infra. Infra seemed like the obvious choice to me, so I was confused as to why DevTools. Being able to foster closer collaboration between cargo and crates.io makes sense.

@rfcbot rfcbot added the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label Apr 12, 2024
@rfcbot
Copy link
Collaborator

rfcbot commented Apr 12, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Currently awaiting signoff of all team members in order to enter the final comment period. label Apr 12, 2024
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this RFC. and removed final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. labels Apr 22, 2024
@rfcbot
Copy link
Collaborator

rfcbot commented Apr 22, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@ehuss
Copy link
Contributor

ehuss commented Apr 24, 2024

Thanks everyone! The @rust-lang/leadership-council has decided to accept this RFC.

@carols10cents can you follow up with updating the team repo whenever you have a chance? It should look something like rust-lang/team#1228. I can help if needed.

@ehuss ehuss merged commit fab408e into rust-lang:master Apr 24, 2024
carols10cents added a commit to carols10cents/team that referenced this pull request Apr 25, 2024
This implements [RFC#3595], which entails:

- Moving the crates.io team to be a subteam of devtools
- Removing @carols10cents from Leadership Council

[RFC#3595]: rust-lang/rfcs#3595
@carols10cents
Copy link
Member Author

@carols10cents can you follow up with updating the team repo whenever you have a chance? It should look something like rust-lang/team#1228. I can help if needed.

Done! rust-lang/team#1439

@carols10cents carols10cents deleted the move-crates-io-under-dev-tools branch April 25, 2024 13:46
rylev pushed a commit to rust-lang/team that referenced this pull request Apr 26, 2024
This implements [RFC#3595], which entails:

- Moving the crates.io team to be a subteam of devtools
- Removing @carols10cents from Leadership Council

[RFC#3595]: rust-lang/rfcs#3595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this RFC. T-leadership-council Relevant to the Leadership Council, which will review and decide on this RFC. to-announce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants