Translate cmd tests to use async LSP client

[Xanewok]

This translates our cmd-based tests to use the LSP client introduced in #1223.

Some anecdotal benchmarks (Xubuntu 18.04, Ryzen 2600) before and after translating:

$ time cargo test cmd_
real    0m3,498s
user    0m8,379s
sys     0m2,710s

$ time cargo test cmd_ --release
real    0m3,059s
user    0m5,585s
sys     0m2,512s

$ time cargo test client_
real    0m3,465s
user    0m7,197s
sys     0m1,926s

$ time cargo test client_ --release
real    0m3,053s
user    0m4,977s
sys     0m1,825s

It seems that synchronization overhead caused by running multiple RLS and rustc instances in-process still outweighs spawning separate processes per test 🎉 That means we don't lose performance (and actually benefit) from switching over.

I plan on translating the remaining tests in tests_old as a separate PR.

r? @alexheretic

[alexheretic]

Yep I can't easily run this at the moment with the compilation issues, but the direction looks good to me.

This is test code too so I'd just go ahead and merge.

[alexheretic]

let bin = rls.future_diagnostics("src/main.rs");
let bin = rls.runtime().block_on(bin).unwrap();

Is it true that these test block forever now, instead of timing out? That seems bad, as the possibility of the message never arriving is definitely something that the test should handle in a useful way.

[Xanewok]

Ah, nice catch! Yeah, we need to time out here as well, my bad.

…

On Mon, 21 Jan 2019 at 11:11, Alex Butler ***@***.***> wrote: let bin = rls.future_diagnostics("src/main.rs");let bin = rls.runtime().block_on(bin).unwrap(); Is it true that these test block forever now, instead of timing out? That seems bad, as the possibility of the message never arriving is definitely something that the test should handle in a useful way. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1244 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC8y3S6iU-SiBhEgc14oXqJ0T_Q0Stlcks5vFZJEgaJpZM4aJzSC> .

[bors]

☔ The latest upstream changes (presumably #1230) made this pull request unmergeable. Please resolve the merge conflicts.

[Xanewok]

Instead of exposing bare Runtime, we now allow to block_on in test code where we always add a timeout, so the user test code can't block indefinitely.

@bors r=alexheretic

[bors]

📌 Commit 663e437 has been approved by alexheretic

[bors]

⌛ Testing commit 663e437 with merge 968129d...

[bors]

☀️ Test successful - checks-travis
Approved by: alexheretic
Pushing 968129d to master...