This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Clear CARGO_TARGET_DIR for tests. #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah that makes a lot of sense now, thanks! I see that's the equivalent of https://github.com/rust-lang/cargo/blob/d5723eb81a5a6755c0da6a2627f18318c031721d/tests/testsuite/support/mod.rs#L1697. |
Xanewok
added a commit
to Xanewok/rust
that referenced
this pull request
Jun 9, 2019
This includes rust-lang/rls#1482 which should finally fix the spurious tests in Rust CI (test-pass -> test-fail).
This was referenced Jun 9, 2019
Closed
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 10, 2019
Update RLS This includes rust-lang/rls#1482 which should finally fix the spurious tests RLS in Rust CI (test-pass -> test-fail). r? @oli-obk cc @ehuss
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
CARGO_TARGET_DIR=somedir cargo testwould cause every test to reuse the same target dir, causing them to stomp on each other's files. This changes it so thatCARGO_TARGET_DIRis cleared, and each invocation of rls in the tests will use the target directory in the project where it runs.Fixes #1466.