Skip to content

Commit

Permalink
remove unicode-ident dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
max-heller committed Aug 1, 2023
1 parent 91581be commit a743903
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/ide-completion/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ itertools = "0.10.5"

once_cell = "1.17.0"
smallvec.workspace = true
unicode-ident = "1.0.0"


# local deps
Expand Down
4 changes: 2 additions & 2 deletions crates/ide-completion/src/item.rs
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,8 @@ impl Builder {
// `PartialOrd` because it has an alias of ">".
.filter(|alias| {
let mut chars = alias.chars();
chars.next().is_some_and(unicode_ident::is_xid_start)
&& chars.all(unicode_ident::is_xid_continue)
chars.next().is_some_and(char::is_alphabetic)
&& chars.all(|c| c.is_alphanumeric() || c == '_')
})
// Deliberately concatenated without separators as adding separators e.g.
// `alias1, alias2` results in LSP clients continuing to display the completion even
Expand Down

0 comments on commit a743903

Please sign in to comment.