[Tracking issue] rust-analyzer in-tree build prerequisites #12818
Comments
fasterthanlime
changed the title
bors
added a commit
that referenced
this issue
Jul 20, 2022
Enable (and fix) extra lint groups required for in-tree build This enables 3 lint groups that are required to build rust-analyzer as an "in-tree" (git subtree) tool in `rust-lang/rust`, and fixes all relevant diagnostics. This change is tracked in: * #12818 Maintainer impact: more warnings, should be easy enough to fix them (it's mostly looking out for "rust-2015-isms", the lint group is poorly named). If you forget some, they'll show up during a `ra=>rust` sync.
bors
added a commit
that referenced
this issue
Jul 20, 2022
Rename proc macro server from 'Rustc' to 'RustAnalyzer' Related to: * #12818 This is mostly a courtesy PR for the sake of rustc maintainers. When they looked at `proc-macro-srv`, they noticed the server was named `Rustc` — probably because of historical copy-paste. Only rustc's proc macro server should be named `Rustc`, ra's can be named `RustAnalyzer`. Maintainer impact: There's no semantic changes in this PR, only naming. One test snapshot was updated since "proc macro server types" were used to test traits somewhere else and I renamed those too, why not.
bors
added a commit
that referenced
this issue
Jul 20, 2022
Remove `check_merge_commits` test Due to the way "git subtree" works, the `check_merge_commits` test _will_ find merge commits and fail, so we simply skip it. This changed is tracked in: * #12818 Maintainer impact: none
fasterthanlime
changed the title
bors
added a commit
that referenced
this issue
Jul 20, 2022
…eykril Build proc-macro-test-impl out-of-tree Building it in-place fails in rust CI because the source directory is read-only. This changes `proc-macro-test`'s build script to first copy `imp` under `OUT_DIR` (which is read-write). It also prints stdout/stderr for the nested cargo invocation, should it fail. (I've seen failures in rust CI that I couldn't explain, and when they take 25 minutes to reproduce, you want to have that info) This change is tracked in: * #12818 Maintainer impact: none.
bors
added a commit
that referenced
this issue
Jul 20, 2022
…asterthanlime Build proc-macro-test-impl out-of-tree Building it in-place fails in rust CI because the source directory is read-only. This changes `proc-macro-test`'s build script to first copy `imp` under `OUT_DIR` (which is read-write). It also prints stdout/stderr for the nested cargo invocation, should it fail. (I've seen failures in rust CI that I couldn't explain, and when they take 25 minutes to reproduce, you want to have that info) This change is tracked in: * #12818 Maintainer impact: none.
bors
added a commit
that referenced
this issue
Jul 20, 2022
Add proc-macro-srv integration test that clones literals This exercises some of the upcoming proc_macro bridge changes. It should also pass for all supported ABIs, with the older-style bridge. This changed is tracked in: * #12818
bors
added a commit
that referenced
this issue
Jul 22, 2022
Introduce proc-macro-srv/sysroot-abi Still a WIP. This change is tracked by: * #12818
|
All of these have landed, I'm moving on to making a subtree PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The rationale for "why move from submodule to subtree" is in:
The proof of concept PR is here:
This is a list of what needs to happen before
rust-analyzerthe realrust-lang/rustPR to re-add it as a subtree can happen:check_merge_commitstest #12829I'll expand the list until the research PR passes in CI, and try to land all these changes as separate rust-analyzer PRs.
The text was updated successfully, but these errors were encountered: