Complete extern crates in extern crate items

[Veykril]

extern crate $0 we should complete all crates names from the extern crate prelude for the current crate here

[Spaceface16518]

I figure this issue is low-priority, so I'm going to try to use it to get into contributing to rust-analyzer.

@rustbot claim

[Veykril]

This requires adding a corresponding variant here

rust-analyzer/crates/ide-completion/src/context.rs

Lines 291 to 302 in f1b257f

	pub(super) enum NameRefKind {
	Path(PathCompletionCtx),
	DotAccess(DotAccess),
	/// Position where we are only interested in keyword completions
	Keyword(ast::Item),
	/// The record expression this nameref is a field of and whether a dot precedes the completion identifier.
	RecordExpr {
	dot_prefix: bool,
	expr: ast::RecordExpr,
	},
	Pattern(PatternContext),
	}

constructing it here

rust-analyzer/crates/ide-completion/src/context/analysis.rs

Lines 593 to 623 in f1b257f

	let segment = match_ast! {
	match parent {
	ast::PathSegment(segment) => segment,
	ast::FieldExpr(field) => {
	let receiver = find_opt_node_in_file(original_file, field.expr());
	let receiver_is_ambiguous_float_literal = match &receiver {
	Some(ast::Expr::Literal(l)) => matches! {
	l.kind(),
	ast::LiteralKind::FloatNumber { .. } if l.syntax().last_token().map_or(false, |it| it.text().ends_with('.'))
	},
	_ => false,
	};
	let kind = NameRefKind::DotAccess(DotAccess {
	receiver_ty: receiver.as_ref().and_then(|it| sema.type_of_expr(it)),
	kind: DotAccessKind::Field { receiver_is_ambiguous_float_literal },
	receiver
	});
	return Some(make_res(kind));
	},
	ast::MethodCallExpr(method) => {
	let receiver = find_opt_node_in_file(original_file, method.receiver());
	let kind = NameRefKind::DotAccess(DotAccess {
	receiver_ty: receiver.as_ref().and_then(|it| sema.type_of_expr(it)),
	kind: DotAccessKind::Method { has_parens: method.arg_list().map_or(false, |it| it.l_paren_token().is_some()) },
	receiver
	});
	return Some(make_res(kind));
	},
	_ => return None,
	}
	};

and then adding a new completion module that handles it https://github.com/rust-lang/rust-analyzer/tree/f1b257f4eb4fef74b42fd7135d1cf3884e8b51c9/crates/ide-completion/src/completions

[jmintb]

Can I have a go at this issue? :)

[Veykril]

go ahead!

[Spaceface16518]

Apologies for dropping this. I never managed to get this to work, but feel free to take a look at my fork for any code that may be helpful @jmintb.

master...Spaceface16518:rust-analyzer:master

[jmintb]

I had to focus on uni for a bit, will get back on this now.

[jmintb]

@rustbot claim