Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider expanding the benchmark suite #7950

Open
lnicola opened this issue Mar 9, 2021 · 0 comments
Open

Consider expanding the benchmark suite #7950

lnicola opened this issue Mar 9, 2021 · 0 comments
Labels
A-infra CI and workflow issues C-enhancement Category: enhancement E-medium good first issue S-actionable Someone could pick this issue up and work on it right now

Comments

@lnicola
Copy link
Member

lnicola commented Mar 9, 2021

Once we get in a relatively stable state we should maybe add some more benchmarks. See the discussion in #4186 (comment).

CC @weiznich
@lnicola lnicola added E-medium good first issue S-actionable Someone could pick this issue up and work on it right now labels Mar 9, 2021
@weiznich weiznich mentioned this issue Mar 15, 2021
Merged
bors bot pushed a commit that referenced this issue Mar 15, 2021
@weiznich
Add diesel to the benchmark suite
aa6db3f 
This commit adds diesel to the continuosly run benchmark suite. Diesel
heavily relies internally on macro generated code. Additionally there
are lots of complicated trait releations used as part of their API.
Therefore this benchmark will be quite sensitive to:
* Performance related changes in the macro expanding code
* Performance related changes while resolving trait bounds

CC #7950
bors bot added a commit that referenced this issue Mar 15, 2021
@bors @weiznich
Merge #8030
633637b 
8030: Add diesel to the benchmark suite r=lnicola a=weiznich

This commit adds diesel to the continuosly run benchmark suite. Diesel
heavily relies internally on macro generated code. Additionally there
are lots of complicated trait releations used as part of their API.
Therefore this benchmark will be quite sensitive to:
* Performance related changes in the macro expanding code
* Performance related changes while resolving trait bounds

CC #7950


cc @lnicola 

Co-authored-by: Georg Semmler <github@weiznich.de>
@Veykril Veykril added A-infra CI and workflow issues C-enhancement Category: enhancement labels Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infra CI and workflow issues C-enhancement Category: enhancement E-medium good first issue S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lnicola @Veykril