-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version strings are still wrong #8571
Comments
Nightly version strings look rather odd too: Nightly version string for 18th of April: As a user, I find those a bit counter-intuitive:
I would preferred a nightly version string that could instantly show when this nightly was created and what code was used for that, for instance: |
The
The presence of the |
That also feels odd, since we're releasing nightly every day and while we've been trying to release some extra releases recently, 8 extra builds feels odd.
I've noted that
Yes, my point is to strongly distinguish nightlies from other untagged releases such as local builds, to eliminate any possible confusion. But that's least of my concerns related to version strings. |
The extra release wasn't actually tagged or released, so it doesn't count. In that example there are 9 commits on the 18th, which sounds reasonable. I'm not sure what the 8 you mention is.
They are commits, not builds.
Why
I think we can pass |
Oh, never mind me, I have to wake up apparently: I've thought about the # of builds, not # of commits even after reading your comment, sorry.
I'm trying to act as a r-a user that usually don't have any r-a code checked out (and I myself often prefer GitHub over Yet GitHub link I've posted above does not show that commit for some reason ergo the confusion. |
That's a strange workflow, I usually copy the hash prefix and put it in the URL like 19fc1f333. It doesn't show up for you because |
Thank you for the explanations, now I feel even more flattened 😬 Feels like I was wrong from the start and bring no extra sense with these comments, so clean them if you want to, while I'm trying to adjust to a different workflow. |
No worries, it's Monday. It was good feedback, but I think using the standard |
Can we create the tag locally before building the release? I didn't find in the release workflow where the tagging actually happens. |
The tagging is done by the |
Hm.... I think "date", "commit hash" and "release" channel are just dissimilar bits of meta, and that it might not be best to try to cajole git to give us them all. How about we do this?
|
So, I imagine a string like this will be suitable for the users:
I am also wondering, should be have {
"commit": "g75371eb0f",
"buildDate": "2021-04-12",
"channel": "dev",
} I feel that some folks might be parsing this output, so having a stable breaking JSON version seems good? EDIT:
Clearly, I am one more person in the thread who needs a wake-up pu'er |
While we're on the subject of version numbers, I'd like to bump rust-analyzer/rust-analyzer.github.io#56 for attention if possible |
So I have a nightly plugin version, nightly checkbox in settings toggled and I don't see a date and see |
Ok, so more details then: I'm using macOs, so presumably something during its binary build process also interferes with the dates? |
well, at least I got linux right :D |
#8666 should fix it |
@SomeoneToIgnore could you check what result this command gives on mac https://github.com/rust-analyzer/rust-analyzer/blob/eee50b6921662dee766c987e1a0b15b371e141d1/crates/rust-analyzer/build.rs#L58 ? |
the only thing resembling UTC I could locate in
mac has pretty weird binutils indeed, but weird that we don't fail on such cases. |
It treats this parameter quite liberally though, so I cannot be sure it understands my
presence |
Found it:
|
8668: Use more cross-platform utc `date` argument r=matklad a=SomeoneToIgnore Part of #8571 ``` $ docker run -it --rm ubuntu:20.04 bash root@7393d1e7bbad:/# date -u +%Y-%m-%d 2021-04-26 ``` ``` $ date -u +%Y-%m-%d 2021-04-26 $ uname -a Darwin alaptop.local 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64 ``` Some of the places where I've change this do not really require it (since macos bin would have failed with `--iso` param also), but I've changed them for consistency. Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
We use
git describe
to get a version string, but the release is tagged only after uploading the artifacts to GitHub. This means that we make a version string using the previous release name.One way to fix this would be to force a certain version string in the workflow for non-nightly releases, but it feels a bit hacky.
The text was updated successfully, but these errors were encountered: