Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Go to implementation of trait methods #12549

Merged
merged 16 commits into from Jul 18, 2022
Merged

feat: Go to implementation of trait methods #12549

merged 16 commits into from Jul 18, 2022

Commits on Jun 23, 2022

  1. goto where trait method impl

    @bitgaoshu @flodiebold
    bitgaoshu authored and flodiebold committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1ef5e14 View commit details
    Browse the repository at this point in the history

  2. reformat code

    @bitgaoshu @flodiebold
    bitgaoshu authored and flodiebold committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1064c75 View commit details
    Browse the repository at this point in the history

  3. Various cleanups 

     - remove Valid, it serves no purpose and just obscures the diff
 - rename some things
 - don't use is_valid_candidate when searching for impl, it's not necessary
    @flodiebold
    flodiebold committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    29f01cd View commit details
    Browse the repository at this point in the history

  4. Add two more tests

    @flodiebold
    flodiebold committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    f410fdf View commit details
    Browse the repository at this point in the history

  5. Fix unstable feature use

    @flodiebold
    flodiebold committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    36fadc4 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. functions resolve to impl

    @bitgaoshu
    bitgaoshu committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    6ecabe3 View commit details
    Browse the repository at this point in the history

  2. fix some test due to resolve to where trait m impl

    @bitgaoshu
    bitgaoshu committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    9e6bff7 View commit details
    Browse the repository at this point in the history

  3. fix test in qualify_method: stay in trait path

    @bitgaoshu
    bitgaoshu committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    9ea8d58 View commit details
    Browse the repository at this point in the history

  4. highlight: trait path

    @bitgaoshu
    bitgaoshu committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    353829f View commit details
    Browse the repository at this point in the history

  5. rename "trait_def" to "def_in_trait"

    @bitgaoshu
    bitgaoshu committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    900b420 View commit details
    Browse the repository at this point in the history

  6. fix test in resolve_proc_macro: Foo is Owner

    @bitgaoshu
    bitgaoshu committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    e3b1303 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2022

  1. restore sth

    @bitgaoshu
    bitgaoshu committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    82c1b31 View commit details
    Browse the repository at this point in the history

  2. add test for suggest_name

    @bitgaoshu
    bitgaoshu committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    0dbc091 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. add test for item same name

    @bitgaoshu
    bitgaoshu committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    408fa14 View commit details
    Browse the repository at this point in the history

  2. WellFormed -> Holds

    @bitgaoshu
    bitgaoshu committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    dcb4837 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Move convert_to_def_in_trait into ide-db

    @Veykril
    Veykril committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    38c11be View commit details
    Browse the repository at this point in the history