feat: MIR episode 4 #14664
Merged
feat: MIR episode 4 #14664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Apr 27, 2023
crates/hir-ty/src/infer.rs
Outdated
| use crate::TraitEnvironment; | ||
| use crate::{ |
There was a problem hiding this comment.
huh, did r-a fail at merging this into the use tree here?
There was a problem hiding this comment.
Yes, when I remove it and use assist, it will add it here again.
lowr
reviewed
Apr 28, 2023
HKalbasi
force-pushed
the
mir
branch
2 times, most recently
from
3fc735d
to
ee76b04
Compare
|
☔ The latest upstream changes (presumably #14690) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced May 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lowering, it now supports overloaded and arith assignment binary operators, statics. and constants in patterns. There is now 252 functions that we fail to emit mir for them, and the majority of them are due type mismatches or other deep and unrelated issues (but it isn't done yet, for example slice patterns and destructing assignment is not implemented yet).
In evaluating, it now can evaluate associated constants in traits (so now typenum's
U5::ToConstshould work), allocator functions, atomic intrinsics, and some more things. It also provides a (hacky) basis for making progress in #14275. I also added aInterpretcode lens toRunandDebugwhen the experimentalinterpret testsis enabled (previously it showed result in hover, which was unusable even for debugging)Changes in unrelated files are:
beforeaftersig_ty.A salsa input for retrieving the path of a file id, used in emitting stack trace for interpret result.