Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Partially support panic message in MirEvalError #14843

Merged
merged 1 commit into from
May 18, 2023

Conversation

HKalbasi
Copy link
Member

And bring the metrics back, by using ::core instead of $crate in format_args! (it looks like eager macros don't support them).

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2023
@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented May 18, 2023

📌 Commit 4adfbbf has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 18, 2023

⌛ Testing commit 4adfbbf with merge 09d1265...

@bors
Copy link
Collaborator

bors commented May 18, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 09d1265 to master...

@bors bors merged commit 09d1265 into rust-lang:master May 18, 2023
10 checks passed
@lnicola lnicola changed the title Partially support panic message in MirEvalError internal: Partially support panic message in MirEvalError May 18, 2023
@Veykril
Copy link
Member

Veykril commented May 18, 2023

This increased memory usage on self by ~170mb

@HKalbasi HKalbasi mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants