Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter out unused cargo features from config #14910

Merged
merged 1 commit into from
May 26, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented May 26, 2023

Closes #11836

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2023
@@ -58,7 +58,6 @@ jobs:
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 20
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that we still had this as well, we can drop that since we no longer have the relevant CI check running that needed it

@Veykril
Copy link
Member Author

Veykril commented May 26, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented May 26, 2023

📌 Commit 835a181 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 26, 2023

⌛ Testing commit 835a181 with merge 77e24b3...

bors added a commit that referenced this pull request May 26, 2023
Filter out unused cargo features from config

Closes #11836
@bors
Copy link
Collaborator

bors commented May 26, 2023

💔 Test failed - checks-actions

@Veykril
Copy link
Member Author

Veykril commented May 26, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented May 26, 2023

📌 Commit 35b208a has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 26, 2023

⌛ Testing commit 35b208a with merge 7c81fff...

@bors
Copy link
Collaborator

bors commented May 26, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7c81fff to master...

@bors bors merged commit 7c81fff into rust-lang:master May 26, 2023
7 checks passed
@Veykril Veykril deleted the cargo-features branch May 26, 2023 20:48
@lnicola lnicola changed the title Filter out unused cargo features from config fix: Filter out unused cargo features from config May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-analyzer.cargo.features can break running of tests in workspaces
3 participants