fix: Emit '_ for lifetime generics in HirDisplay
#14978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
HKalbasi
force-pushed
the
lifetime-display
branch
from
b890052
to
6f514a5
Compare
DropDemBits
reviewed
Jun 5, 2023
We should, that lint should be warn by default anyways, but there was some reason as to why some of the 2018 lints are still allowed by default. |
HKalbasi
force-pushed
the
lifetime-display
branch
from
6f514a5
to
5531d46
Compare
|
@bors r+ |
What was the reason? |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
'_ for lifetime generics in HirDisplay'_ for lifetime generics in HirDisplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the generated code not linted by
rust_2018_idiomslint. But that is an allow by default lint, so should we do this? Maybe we should only do this forDisplayTarget::SourceCode?