Fix size_of_val and support min_align_of_val #15222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jul 6, 2023
Fix size_of_val and support min_align_of_val
|
💔 Test failed - checks-actions |
|
@bors r+ |
|
@bors r- |
|
@bors r+ |
Veykril
reviewed
Jul 6, 2023
| message += &std::string::String::from_utf8_lossy(piece_data); | ||
| } | ||
| Some(message) | ||
| let x = self.db.crate_def_map(self.crate_id).crate_root(); |
There was a problem hiding this comment.
x isn't really a great variable name, especially in this case here. You tend to do that a lot which is why I'm raising that here. (and in cases where we need a quick non describing name like in mapping closures etc we tend to use it, https://github.com/rust-lang/rust-analyzer/blob/master/docs/dev/style.md#variable-naming)
There was a problem hiding this comment.
I will make a de-x-ify follow up PR to remove all xs everywhere.
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.