Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Migrate more assists to use the structured snippet API #15231

Merged
merged 9 commits into from
Jul 10, 2023
Merged

internal: Migrate more assists to use the structured snippet API #15231

merged 9 commits into from
Jul 10, 2023

Commits on Jul 8, 2023

  1. internal: add add_tabstop_{before,after}_token

    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    4de7cbe View commit details
    Browse the repository at this point in the history

  2. add attr-related make functions

    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    c017233 View commit details
    Browse the repository at this point in the history

  3. add AttrsOwnerEdit::add_attr

    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    419f641 View commit details
    Browse the repository at this point in the history

  4. Migrate generate_derive to mutable ast

    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    25088fc View commit details
    Browse the repository at this point in the history

  5. Migrate wrap_return_type_in_result to mutable ast

    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    f8b6b4c View commit details
    Browse the repository at this point in the history

  6. Migrate generate_delegate_methods to mutable ast

    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    58e2053 View commit details
    Browse the repository at this point in the history

  7. Match indentation of generated delegate method

    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    09a3bd5 View commit details
    Browse the repository at this point in the history

  8. refactor: simplify generate_delegate_method 

    Can actually split out adding the functions from  getting the impl to
update or create thanks to being able to refer to the impl ast node.

FIXME Context:
Unfortunately we can't adjust the indentation of the newly added function
inside of `ast::AssocItemList::add_item` since for some reason the `todo!()`
placeholder generated by `add_missing_impl_members` and
`replace_derive_with_manual_impl` gets indented weirdly.
    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    2eb5064 View commit details
    Browse the repository at this point in the history

  9. fix: Don't panic for different/missing delimiters

    @DropDemBits
    DropDemBits committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    5fddf3e View commit details
    Browse the repository at this point in the history