Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pinned version of lsp-types #15428

Merged
merged 1 commit into from Aug 9, 2023
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 9, 2023

lsp-types published a new patch version that breaks semver with the proposed feature set (this is intended and documented), we unfortunately forgot to specify the patch version for the pinned version so this breaks us.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2023
@Veykril
Copy link
Member Author

Veykril commented Aug 9, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 9, 2023

📌 Commit 7e04142 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 9, 2023

⌛ Testing commit 7e04142 with merge 05b0612...

@bors
Copy link
Collaborator

bors commented Aug 9, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 05b0612 to master...

@bors bors merged commit 05b0612 into rust-lang:master Aug 9, 2023
10 checks passed
@Veykril Veykril deleted the lsp-types-pin branch August 14, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants