-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Sync from downstream #15494
Merged
Merged
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 96b60ed - Browse repository at this point
Copy the full SHA 96b60edView commit details -
Rollup merge of #114562 - Trolldemorted:thiscall, r=oli-obk
stabilize abi_thiscall Closes rust-lang/rust#42202, stabilizing the use of the "thiscall" ABI. FCP was substituted by a poll, and the poll has been accepted.
Configuration menu - View commit details
-
Copy full SHA for 3ea1928 - Browse repository at this point
Copy the full SHA 3ea1928View commit details
Commits on Aug 9, 2023
-
feat:
riscv-interrupt-{m,s}
calling conventionsSimilar to prior support added for the mips430, avr, and x86 targets this change implements the rough equivalent of clang's [`__attribute__((interrupt))`][clang-attr] for riscv targets, enabling e.g. ```rust static mut CNT: usize = 0; pub extern "riscv-interrupt-m" fn isr_m() { unsafe { CNT += 1; } } ``` to produce highly effective assembly like: ```asm pub extern "riscv-interrupt-m" fn isr_m() { 420003a0: 1141 addi sp,sp,-16 unsafe { CNT += 1; 420003a2: c62a sw a0,12(sp) 420003a4: c42e sw a1,8(sp) 420003a6: 3fc80537 lui a0,0x3fc80 420003aa: 63c52583 lw a1,1596(a0) # 3fc8063c <_ZN12esp_riscv_rt3CNT17hcec3e3a214887d53E.0> 420003ae: 0585 addi a1,a1,1 420003b0: 62b52e23 sw a1,1596(a0) } } 420003b4: 4532 lw a0,12(sp) 420003b6: 45a2 lw a1,8(sp) 420003b8: 0141 addi sp,sp,16 420003ba: 30200073 mret ``` (disassembly via `riscv64-unknown-elf-objdump -C -S --disassemble ./esp32c3-hal/target/riscv32imc-unknown-none-elf/release/examples/gpio_interrupt`) This outcome is superior to hand-coded interrupt routines which, lacking visibility into any non-assembly body of the interrupt handler, have to be very conservative and save the [entire CPU state to the stack frame][full-frame-save]. By instead asking LLVM to only save the registers that it uses, we defer the decision to the tool with the best context: it can more accurately account for the cost of spills if it knows that every additional register used is already at the cost of an implicit spill. At the LLVM level, this is apparently [implemented by] marking every register as "[callee-save]," matching the semantics of an interrupt handler nicely (it has to leave the CPU state just as it found it after its `{m|s}ret`). This approach is not suitable for every interrupt handler, as it makes no attempt to e.g. save the state in a user-accessible stack frame. For a full discussion of those challenges and tradeoffs, please refer to [the interrupt calling conventions RFC][rfc]. Inside rustc, this implementation differs from prior art because LLVM does not expose the "all-saved" function flavor as a calling convention directly, instead preferring to use an attribute that allows for differentiating between "machine-mode" and "superivsor-mode" interrupts. Finally, some effort has been made to guide those who may not yet be aware of the differences between machine-mode and supervisor-mode interrupts as to why no `riscv-interrupt` calling convention is exposed through rustc, and similarly for why `riscv-interrupt-u` makes no appearance (as it would complicate future LLVM upgrades). [clang-attr]: https://clang.llvm.org/docs/AttributeReference.html#interrupt-risc-v [full-frame-save]: https://github.com/esp-rs/esp-riscv-rt/blob/9281af2ecffe13e40992917316f36920c26acaf3/src/lib.rs#L440-L469 [implemented by]: https://github.com/llvm/llvm-project/blob/b7fb2a3fec7c187d58a6d338ab512d9173bca987/llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp#L61-L67 [callee-save]: https://github.com/llvm/llvm-project/blob/973f1fe7a8591c7af148e573491ab68cc15b6ecf/llvm/lib/Target/RISCV/RISCVCallingConv.td#L30-L37 [rfc]: rust-lang/rfcs#3246
Configuration menu - View commit details
-
Copy full SHA for c9bc45f - Browse repository at this point
Copy the full SHA c9bc45fView commit details
Commits on Aug 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 93b6838 - Browse repository at this point
Copy the full SHA 93b6838View commit details -
Configuration menu - View commit details
-
Copy full SHA for 465aaed - Browse repository at this point
Copy the full SHA 465aaedView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6b97e6 - Browse repository at this point
Copy the full SHA d6b97e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ddc6a7 - Browse repository at this point
Copy the full SHA 4ddc6a7View commit details
Commits on Aug 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 59f9c95 - Browse repository at this point
Copy the full SHA 59f9c95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 883f16d - Browse repository at this point
Copy the full SHA 883f16dView commit details
Commits on Aug 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 30d8aa1 - Browse repository at this point
Copy the full SHA 30d8aa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4cf405 - Browse repository at this point
Copy the full SHA a4cf405View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6caf79c - Browse repository at this point
Copy the full SHA 6caf79cView commit details
Commits on Aug 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b4576b5 - Browse repository at this point
Copy the full SHA b4576b5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.