New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scip: Allow customizing cargo config. #15633
Conversation
r? @lnicola This is useful for use-cases like mozsearch/mozsearch#652 (but also for any custom workspace shenanigans for which the rust-analyzer configuration is useful). |
Regarding mozsearch/mozsearch#652, wouldn't setting
Yeah, maybe that. I'm just not sure we want to support this kind of configuration. But if we do, I think we want it as a global (top-level) option. It could also be useful for And it should probably be marked as unstable, since |
No, it's already set a few lines before calling
Yeah, in practice, eventually I want to use this for Firefox, which has a much complex workspace / vendoring set-up and requires also
I think they could be useful but probably requires quite a bit more work to generalize this.
Yeah, making them unstable is fine with me. My understanding is that these are effectively already unstable tho?
I'm more than happy to adapt to changes in this area if the way of doing this changes in the future :) |
All right, let's keep it only for @bors delegate+ |
Then it should already work AFAICT. But we only use |
This will most likely be superceded by rust-analyzer.toml once we have that |
Re-use the LSP config json for simplicity.
d4ab86b
to
791e6c8
Compare
Thanks! Rebased and removed that sysroot bit since it is indeed redundant. Just confirmed that using scip without config file still gets @bors r=lnicola |
☀️ Test successful - checks-actions |
Re-use the LSP config json for simplicity.