Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for the default action of the status bar click action in VSCode #15707

Merged
merged 1 commit into from Oct 4, 2023
Merged

Add configuration for the default action of the status bar click action in VSCode #15707

merged 1 commit into from Oct 4, 2023

Conversation

dfireBird
Copy link
Contributor

Fixes #15441

Please suggest any changes if necessary.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2023
Veykril
Veykril reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving it some more thought, I think I agree with your statusBar.clickAction name after all. There is no reason for us to append default after all

editors/code/package.json Outdated Show resolved Hide resolved
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2023
@dfireBird dfireBird force-pushed the default-statusbar-action-config branch from 9da8466 to ab091b7 Compare October 4, 2023 15:38
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2023
@lnicola
Copy link
Member

lnicola commented Oct 4, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 4, 2023

📌 Commit ab091b7 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 4, 2023

⌛ Testing commit ab091b7 with merge b57658d...

@bors
Copy link
Collaborator

bors commented Oct 4, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing b57658d to master...

@bors bors merged commit b57658d into rust-lang:master Oct 4, 2023
10 checks passed
@dfireBird dfireBird deleted the default-statusbar-action-config branch October 4, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril left review comments

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuring the default action of the status bar click action in VSCode
5 participants
@dfireBird @lnicola @bors @Veykril @rustbot