Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add incorrect case diagnostics for module names #15736

Merged
merged 1 commit into from Oct 20, 2023
Merged

fix: add incorrect case diagnostics for module names #15736

merged 1 commit into from Oct 20, 2023

Conversation

rmehri01
Copy link
Contributor

@rmehri01 rmehri01 commented Oct 9, 2023

Adds diagnostics for checking both inline and file module names are snake case.

Closes #15678

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2023
@HKalbasi
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Oct 20, 2023

📌 Commit 36eac9a has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 20, 2023

⌛ Testing commit 36eac9a with merge bd38871...

@bors
Copy link
Collaborator

bors commented Oct 20, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing bd38871 to master...

@bors bors merged commit bd38871 into rust-lang:master Oct 20, 2023
10 checks passed
@rmehri01 rmehri01 deleted the 15678_module_incorrect_case_diagnostics branch October 20, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No case diagnostics for module names
4 participants
@rmehri01 @HKalbasi @bors @rustbot