Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add replace_is_ok_with_if_let_ok assist #15752

Merged
merged 2 commits into from Oct 13, 2023
Merged

feat: add replace_is_ok_with_if_let_ok assist #15752

merged 2 commits into from Oct 13, 2023

Conversation

Young-Flash
Copy link
Member

@Young-Flash Young-Flash commented Oct 13, 2023 •
edited

if_is_ok_assist

following #15743

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2023
HKalbasi
HKalbasi approved these changes Oct 13, 2023
View reviewed changes
crates/ide-assists/src/lib.rs Outdated Show resolved Hide resolved
@HKalbasi
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 13, 2023

📌 Commit 5bbca22 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 13, 2023

⌛ Testing commit 5bbca22 with merge 862693f...

@bors
Copy link
Collaborator

bors commented Oct 13, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 862693f to master...

@bors bors merged commit 862693f into rust-lang:master Oct 13, 2023
10 checks passed
@Young-Flash Young-Flash deleted the replace_is_method_with_if_let_method branch October 13, 2023 08:37
@Young-Flash Young-Flash mentioned this pull request Oct 14, 2023
Merged
bors added a commit that referenced this pull request Oct 15, 2023
@bors
Auto merge of #15755 - Young-Flash:cursor_selection, r=lnicola
65532e4 
fix: make cursor select at _tmp

Here make cursor select at `_tmp` atuomatically after the assist apply. Refer to [vscode snippet placeholder](https://code.visualstudio.com/docs/editor/userdefinedsnippets#_placeholders).

![cursor_selection](https://github.com/rust-lang/rust-analyzer/assets/71162630/a7866efe-2d54-488b-903e-9df039f34a7e)

following #15752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HKalbasi HKalbasi HKalbasi approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Young-Flash @HKalbasi @bors @rustbot