Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add command for only opening external docs and attempt to fix vscode-remote issue #15779

Merged
merged 1 commit into from Oct 18, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Oct 18, 2023

opening URI in a remote env causes vscode to ask the OS to handle vscode-remote URIs as there is no handler registered for such a scheme. This attempts to instruct vscode to handle those.

This is untested, as I can't figure out how to open a debug session on WSL rn.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2023
@Veykril
Copy link
Member Author

Veykril commented Oct 18, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2023

📌 Commit 4296fe5 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 18, 2023

⌛ Testing commit 4296fe5 with merge 4586a6b...

@bors
Copy link
Collaborator

bors commented Oct 18, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 4586a6b to master...

@bors bors merged commit 4586a6b into rust-lang:master Oct 18, 2023
10 checks passed
@lnicola lnicola changed the title Add command for only opening external docs and attempt to fix vscode-remote issue fix: Add command for only opening external docs and attempt to fix vscode-remote issue Oct 18, 2023
@Veykril Veykril deleted the open-docs branch November 12, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants