Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import trait if needed for unqualify_method_call assist #15780

Merged
merged 2 commits into from Oct 23, 2023

Conversation

Young-Flash
Copy link
Member

@Young-Flash Young-Flash commented Oct 18, 2023

before:

before

after:

after

follow up #13825

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2023
@Young-Flash
Copy link
Member Author

ready for review

cc @lnicola

@lnicola
Copy link
Member

lnicola commented Oct 23, 2023

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 23, 2023

📌 Commit 45ee88f has been approved by lnicola

It is now in the queue for this repository.

@lnicola lnicola changed the title fix: auto import trait if needed for unqualify_method_call assist fix: import trait if needed for unqualify_method_call assist Oct 23, 2023
@bors
Copy link
Collaborator

bors commented Oct 23, 2023

⌛ Testing commit 45ee88f with merge 2f6961a...

@bors
Copy link
Collaborator

bors commented Oct 23, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 2f6961a to master...

@bors bors merged commit 2f6961a into rust-lang:master Oct 23, 2023
10 checks passed
@Young-Flash Young-Flash deleted the auto_import branch October 24, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants