Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make extract_variable assist in place #15809

Merged
merged 2 commits into from Oct 28, 2023
Merged

feat: make extract_variable assist in place #15809

merged 2 commits into from Oct 28, 2023

Conversation

Young-Flash
Copy link
Member

@Young-Flash Young-Flash commented Oct 27, 2023 •
edited

close #15796

extract_variable_without_select

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2023
HKalbasi
HKalbasi approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@HKalbasi HKalbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the assist inapplicable if the expression has type ()?

@HKalbasi
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 28, 2023

📌 Commit 7186a28 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 28, 2023

⌛ Testing commit 7186a28 with merge f493207...

@bors
Copy link
Collaborator

bors commented Oct 28, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing f493207 to master...

@bors bors merged commit f493207 into rust-lang:master Oct 28, 2023
10 checks passed
@lnicola lnicola mentioned this pull request Nov 3, 2023
Closed
@Young-Flash Young-Flash deleted the extract_variable_in_place branch November 4, 2023 08:28
@Young-Flash Young-Flash mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HKalbasi HKalbasi HKalbasi approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer "Extract variable" assist for statements
4 participants
@Young-Flash @HKalbasi @bors @rustbot