Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Make "Expand macro" command title more explicit #15870

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Nov 11, 2023

Closes #15856.

I opted for "caret", since it's the better term (cursor is the mouse), but I'm not sure how popular it is these days.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 11, 2023
@@ -208,6 +208,7 @@ impl ProjectFolders {
let entry = {
let mut dirs = vfs::loader::Directories::default();
dirs.extensions.push("rs".into());
dirs.extensions.push("toml".into());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@lnicola
Copy link
Member Author

lnicola commented Nov 12, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 12, 2023

📌 Commit cace36c has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 12, 2023

⌛ Testing commit cace36c with merge 1152f59...

@bors
Copy link
Collaborator

bors commented Nov 12, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 1152f59 to master...

@bors bors merged commit 1152f59 into rust-lang:master Nov 12, 2023
10 checks passed
@lnicola lnicola deleted the expand-macro branch November 12, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading command name > rust-analyzer: Expand macro recursively
4 participants