Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle default constant values in trait_impl_missing_assoc_item diagnostic #15911

Merged
merged 1 commit into from Nov 20, 2023
Merged

fix: handle default constant values in trait_impl_missing_assoc_item diagnostic #15911

merged 1 commit into from Nov 20, 2023

Conversation

Young-Flash
Copy link
Member

A patch of #15895, close #15909

cc @Veykril

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2023
lnicola
lnicola approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this should have been in today's release 😔.

@lnicola
Copy link
Member

lnicola commented Nov 20, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 20, 2023

📌 Commit cfc881a has been approved by lnicola

It is now in the queue for this repository.

@lnicola lnicola changed the title fix missing assoc item fix: handle default constant values in trait_impl_missing_assoc_item diagnostic Nov 20, 2023
@bors
Copy link
Collaborator

bors commented Nov 20, 2023

⌛ Testing commit cfc881a with merge 1a5cee1...

@bors
Copy link
Collaborator

bors commented Nov 20, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 1a5cee1 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Nov 20, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 1a5cee1 to master...

@bors bors merged commit 1a5cee1 into rust-lang:master Nov 20, 2023
10 checks passed
@bors
Copy link
Collaborator

bors commented Nov 20, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@lilizoey lilizoey mentioned this pull request Nov 20, 2023
Closed
@Young-Flash
Copy link
Member Author

Young-Flash commented Nov 21, 2023 •
edited

Sorry, this should have been in today's release 😔.

It's okay, after all there are relatively few maintainers while there are a lot of PR. Noticed that there are a few people in R-A org, will R-A team consider expanding maintainers from contributors?

BTW, there is a downstream user affected by the underlying bug which report at godot-rust/gdext#490, maybe we should make a nigthly release in a few days?

@lnicola
Copy link
Member

lnicola commented Nov 21, 2023

Noticed that there are a few people in R-A org, will R-A team consider expanding maintainers from contributors?

Sure, but most (or almost all, if you could see the full list) of the people in there haven't been very active lately.

maybe we should make a nigthly release in a few days

The nightlies are made nightly, so the fix is already out.

@jnicholls jnicholls mentioned this pull request Nov 21, 2023
Merged
@Young-Flash Young-Flash deleted the fix_missing_assoc_item branch November 26, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
4 participants
@Young-Flash @lnicola @bors @rustbot