fix: Improve error handling for top-level let statements
#15961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Nov 30, 2023
Veykril
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
While I'm not really sure if handling a particular case in a special manner is appropriate, it would be good to suppress the excessive number of annoying and unrelated errors.
I'd say it is, new people might be tempted to use let for globals (and rustc also recovers specifically from this)
Veykril
added
S-waiting-on-author
Ah, yeah, indeed. |
This commit addresses the issue of excessive and unrelated errors generated by top-level `let` statements. Now, only a single error is produced, indicating that `let` statements are invalid at the top level.
ohno418
force-pushed
the
top-level-let-stmt
branch
from
4b5ae46
to
e076192
Compare
|
Thanks! |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
let statementslet statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the issue of excessive and unrelated errors generated by top-level
letstatements. Now, only a single error is produced, indicating thatletstatements are invalid at the top level.Fixes #14963.
While I'm not really sure if handling a particular case in a special manner is appropriate, it would be good to suppress the excessive number of annoying and unrelated errors.