New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't make MissingMatchArms
diagnostic for empty match body
#15971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it still runs, but we hide it. Guess it's fine though.
Looks like the test is failing because of the diagnostic range. |
yeah, are there any mark that indicate diagnostic range with the same begin and end like |
You can just make a variant of |
It would be nice to make this more like And making filtering syntax errors in |
ece1195
to
b46f378
Compare
Wow, that actually works? @bors r+ |
☀️ Test successful - checks-actions |
exactly 😄 |
before
after
close #15954