Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix diagnostics panicking when resolving to different files due to macros #16035

Merged
merged 2 commits into from Dec 6, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Dec 6, 2023

Fixes #14968

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2023
@Veykril Veykril changed the title Fix diagnostics panicking when resolving to different files due to macros fix: Fix diagnostics panicking when resolving to different files due to macros Dec 6, 2023
@Veykril
Copy link
Member Author

Veykril commented Dec 6, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 6, 2023

📌 Commit ba01ff4 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 6, 2023

⌛ Testing commit ba01ff4 with merge 77e362c...

@bors
Copy link
Collaborator

bors commented Dec 6, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 77e362c to master...

@bors bors merged commit 77e362c into rust-lang:master Dec 6, 2023
10 checks passed
@lnicola
Copy link
Member

lnicola commented Dec 6, 2023

Should we close #15838?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics calculated from included files report them for the wrong file
4 participants