make ParamLoweringMode accessible #16036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Dec 6, 2023
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
hir-ty, theTyLoweringContexthas functionspub fn with_impl_trait_modeandpub fn with_type_param_mode, which can be used to fine-tune certain lowering properties.Each of these takes one enum (either
pub enum ImplTraitLoweringMode, orpub enum ParamLoweringMode), which encodes the possible configuration options.To then make this usable for other crates,
TyLoweringContextandImplTraitLoweringModeare exported. Unfortuntely,ParamLoweringModeis not. This means that while the method can be called, there are no useful values to call it with.Presumably this is an oversight. It would be great if this was made actually public.