fix: Don't emit "missing items" diagnostic for negative impls #16039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Adding a simple test to the unit tests in @bors delegate+ |
|
✌️ @WaffleLapkin, you can now approve this pull request! If @Veykril told you to " |
rust-cloud-vms
bot
force-pushed
the
don't-emit-missing-assoc-items-diagnostic-for-negative-impls
branch
from
38b8c6d
to
1630477
Compare
|
@bors r=Veykril |
|
☀️ Test successful - checks-actions |
WaffleLapkin
deleted the
don't-emit-missing-assoc-items-diagnostic-for-negative-impls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative impls can't have items, so there is no reason for this diagnostic.
LMK if I should add a test somewhere. Also LMK if that's not how we usually check multiple things in an if in r-a.