Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query for nearest parent block around the hint to resolve #16089

Merged
merged 2 commits into from Dec 11, 2023
Merged

Query for nearest parent block around the hint to resolve #16089

merged 2 commits into from Dec 11, 2023

Conversation

SomeoneToIgnore
Copy link
Contributor

This way, parameter hints will be found for resolution and #15522 (comment) will be fixed

Hopefully that also helps with whatever else (lifetimes', etc.) hints in
#13962

hints are resolved by querying for textDocument/inlayHint with hint's position turned into a [position-1, position+1] range (instead of the original, much wider document range).

This might lead to issues in the future, with e.g. lifetime hints (currently there's nothing to resolve for them and it's fine) that belong to a certain position, but need to have textDocument/inlayHint query for much bigger range than their position+/-1

@SomeoneToIgnore
Query for nearest parent block around the hint to resolve
be6d34b 
This way, parameter hints will be found for resolution
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2023
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Dec 11, 2023
Merged
@Veykril
Copy link
Member

Veykril commented Dec 11, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 11, 2023

📌 Commit 8ae42b5 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 11, 2023

⌛ Testing commit 8ae42b5 with merge 3aa6306...

@bors
Copy link
Collaborator

bors commented Dec 11, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 3aa6306 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Dec 11, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 3aa6306 to master...

@bors bors merged commit 3aa6306 into rust-lang:master Dec 11, 2023
10 checks passed
@bors
Copy link
Collaborator

bors commented Dec 11, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@SomeoneToIgnore SomeoneToIgnore deleted the fix-parameter-inlay-hints-resolution branch December 11, 2023 19:43
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request Dec 12, 2023
Open
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SomeoneToIgnore @Veykril @bors @rustbot