Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mbe): desugar doc correctly for mbe #16158

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix(mbe): desugar doc correctly for mbe #16158

merged 2 commits into from
Dec 19, 2023

Commits on Dec 19, 2023

  1. fix(mbe): desugar doc correctly for mbe 

    Fixes rust-lang#16110.

The way rust desugars doc comments when expanding macros
is rendering it as raw strings delimited with hashes.
Rust-analyzer wasn't aware of this, so the desugared doc
comments wouldn't match correctly when on the LHS of macro
declarations.

This PR fixes this by porting the code used by rustc: https://github.com/rust-lang/rust/blob/4cfdbd328b7171b2328d11b950b1af0978d6b1ef/compiler/rustc_ast/src/tokenstream.rs#L6837
    @saiintbrisson
    saiintbrisson committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    117a28a View commit details
    Browse the repository at this point in the history

  2. fix(mbe): update test

    @saiintbrisson
    saiintbrisson committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    6f58e98 View commit details
    Browse the repository at this point in the history