Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract_struct_from_enum_variant assist should resolve Self generic arg #16199

Merged
merged 6 commits into from Jan 5, 2024
Merged

fix: extract_struct_from_enum_variant assist should resolve Self generic arg #16199

merged 6 commits into from Jan 5, 2024

Conversation

Young-Flash
Copy link
Member

close #16197

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 26, 2023
@Young-Flash
Copy link
Member Author

sorry I miss the case that nested generic arg with Self, corrected now.

it's ready for review.

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2024
@Young-Flash
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 4, 2024
@Veykril
Copy link
Member

Veykril commented Jan 5, 2024

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Jan 5, 2024

📌 Commit 1a9b1b8 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 5, 2024

⌛ Testing commit 1a9b1b8 with merge 5945709...

@bors
Copy link
Collaborator

bors commented Jan 5, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 5945709 to master...

@bors bors merged commit 5945709 into rust-lang:master Jan 5, 2024
10 checks passed
@Young-Flash Young-Flash deleted the extract_struct_with_Self branch January 9, 2024 13:17
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The behavior of the Self type in the Extract struct from enum variant option is not as expected
4 participants
@Young-Flash @Veykril @bors @rustbot