Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add always_allow_fuzzy, query_search_limit config #16207

Closed
wants to merge 1 commit into from

Conversation

danielhuang
Copy link

@danielhuang danielhuang commented Dec 29, 2023

Closes #13564

Similar to #13656

Revisiting since finding completions is now faster (completions taking 50ms with no query_search_limit in medium-sized project)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2023
@bors
Copy link
Collaborator

bors commented Jan 4, 2024

☔ The latest upstream changes (presumably #16261) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added has-merge-commits S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 4, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@bors
Copy link
Collaborator

bors commented Jan 5, 2024

☔ The latest upstream changes (presumably #16268) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Jan 19, 2024

☔ The latest upstream changes (presumably #16398) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril
Copy link
Member

Veykril commented Apr 18, 2024

Closing this, see #13564 (comment)

@Veykril Veykril closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-merge-commits S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: allow disabling of autocompletion-related limits via configuration
4 participants