Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unresolved associated item diagnostic #16222

Merged
merged 1 commit into from Jan 2, 2024

Conversation

rosefromthedead
Copy link
Contributor

I tried to copy from private-assoc-item for this

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2023
@Veykril
Copy link
Member

Veykril commented Jan 2, 2024

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Jan 2, 2024

📌 Commit 5878651 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 2, 2024

⌛ Testing commit 5878651 with merge 426d284...

@bors
Copy link
Collaborator

bors commented Jan 2, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 426d284 to master...

@bors bors merged commit 426d284 into rust-lang:master Jan 2, 2024
10 checks passed
@lnicola lnicola changed the title add unresolved-assoc-item assist feat: add unresolved associated item diagnostic Jan 2, 2024
@lnicola
Copy link
Member

lnicola commented Jan 2, 2024

Can't help but wonder if that's a Theatre of Tragedy reference :-).

image

changelog feat (first contribution) add unresolved_assoc_item diagnostic:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants