fix: parse macro_rules as macro name
#16314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Jan 9, 2024
Veykril
reviewed
Jan 10, 2024
crates/parser/src/grammar/items.rs
Outdated
Comment on lines
436
to
440
| match macro_call_after_excl(p) { | ||
| BlockLike::Block => p.eat(SEMICOLON), | ||
| BlockLike::NotBlock => p.expect(SEMICOLON), | ||
| }; | ||
| m.complete(p, MACRO_CALL); |
There was a problem hiding this comment.
Let's undo this change here again, this is semantically different from the previous behavior. foo!{}; is not a valid item parse
There was a problem hiding this comment.
But wait. Was your coment about not doing the eat or about not having it as macro_call(p: &mut Parser<'_>, m: Marker) or about both? Because I very much prefer the to add the marker to the signature to be consistent with the other functions.
Veykril
added
S-waiting-on-author
It's a call of the third token is neither IDENT or TRY
Urhengulas
force-pushed
the
macro_rule-as-macro-name
branch
from
45d8bfe
to
5916da2
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@rustbot author |
rustbot
added
S-waiting-on-author
Veykril
reviewed
Jan 17, 2024
Urhengulas
force-pushed
the
macro_rule-as-macro-name
branch
from
77cf4d4
to
76c67dd
Compare
|
Thanks! |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Jan 18, 2024
Refactor `macro_call` to be consistent with other functions #16314 (comment)
bors
added a commit
that referenced
this pull request
Jan 18, 2024
Refactor `macro_call` to be consistent with other functions #16314 (comment)
lnicola
changed the title
macro_rules as macro namemacro_rules as macro name
This was referenced May 9, 2024
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes RA parse
macro_rules! {}(note the missing identifier) as aMACRO_CALLinstead ofMACRO_RULES.Fixes #15969.