fix: fix panic when extracting struct from enum variant #16396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Jan 18, 2024
Comment on lines
418
to
419
| let origin_range = sema.original_range(segment.syntax()).range; | ||
| if s_range != origin_range { |
There was a problem hiding this comment.
We can simplify this
Suggested change
| let origin_range = sema.original_range(segment.syntax()).range; | |
| if s_range != origin_range { | |
| let origin_range = sema.original_range(segment.syntax()).range; | |
| if s_range != reference.range { |
Veykril
added
S-waiting-on-author
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it panic at
builder.make_mut(segment), where segment is from macro expand. And the usage reference in orginal macro call isn't aPathSegmentso we can't update it inapply_references, I can't find a way to deal with it properly so here just filter out the reference in macro. LMK if there are better way to fix thistry to close #16328